Intercept Ollama errors before Webview, to display Download/Start options #3740
+35
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Signed-off-by: Fred Bricon <[email protected]>
✅ Deploy Preview for continuedev canceled.
|
|
I decided to remove the Documentation option shown during completion failure, when ollama is not started:
|
sestinj
approved these changes
Jan 15, 2025
|
so actually this PR is based on top of #3725, leveraging the change in the respond signature (now allowing type So do not merge this before #3725, or else there will be a compilation error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3674
Description
Ollama specific errors are intercepted in VS Code's webviewProtocol class, before they're propagated to the webview, so they can be treated the same way as in #3653, and allow users to start or download Ollama if needed.
Checklist
Screenshots
Before:
or, when #3725 is applied:
After:
Testing instructions